Skip to content

[experiment] effect guards#126

Draft
lifeart wants to merge 1 commit intomasterfrom
effect-guards
Draft

[experiment] effect guards#126
lifeart wants to merge 1 commit intomasterfrom
effect-guards

Conversation

@lifeart
Copy link
Copy Markdown
Owner

@lifeart lifeart commented May 10, 2024

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented May 10, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit f90f820
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/663dde17bdb2c90008a6c1eb
😎 Deploy Preview https://deploy-preview-126--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Copy Markdown

Code Coverage Report

Coverage after merging effect-guards into master

76.18%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.7929, 77, 78, 79, ...
utils
   component.ts95.7978, 8, 9, 96, ...
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts98.4390877, 94, 95, 96, ...
   reactive.ts91.5056, 61, 66, 67, ...
   runtime.ts95.7411, 12, 13
   shared.ts79.1396, 97, 98, 99, ...
   vm.ts27, 33, 39, 4, ...
utils/benchmark
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts63.125076, 77, 95, 99, ...
   list.ts93.588070, 74, 75, 76, ...
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts52.3896, 97, 98, 99, ...
   rehydration.ts135, 144, 34, 37, ...

@github-actions
Copy link
Copy Markdown

duration phase no difference [-203ms to 41ms]
renderEnd phase no difference [-1ms to 1ms]
render1000Items1End phase no difference [-9ms to 11ms]
clearItems1End phase no difference [-2ms to 4ms]
render1000Items2End phase no difference [-16ms to 0ms]
clearItems2End phase no difference [0ms to 1ms]
render5000Items1End phase no difference [-34ms to 30ms]
clearManyItems1End phase no difference [0ms to 13ms]
render5000Items2End phase no difference [-37ms to 17ms]
clearManyItems2End phase no difference [-2ms to 38ms]
render1000Items3End phase no difference [-15ms to 6ms]
append1000Items1End phase no difference [-33ms to 4ms]
append1000Items2End phase estimated improvement -28ms [-58ms to -2ms] OR -3.95% [-8.32% to -0.28%]
updateEvery10thItem1End phase no difference [-6ms to 31ms]
updateEvery10thItem2End phase no difference [-17ms to 7ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [0ms to 2ms]
removeSecondRow1End phase no difference [-16ms to 0ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-1ms to 6ms]
paint phase no difference [0ms to 0ms]

[09:35:02] Generating Benchmark Reports [started]
[09:35:07] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant